Re-create purged cluster for databricks_mount for Google Storage
#1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging e8503ac into 0647db0 - view on LGTM.com new alerts:
|
marekbrysa
changed the title
|
@marekbrysa please fix test |
|
@marekbrysa take a look at implementation in #1345 |
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
=======================================
Coverage 90.10% 90.10%
=======================================
Files 121 121
Lines 10123 10128 +5
=======================================
+ Hits 9121 9126 +5
Misses 638 638
Partials 364 364
|
nfx
approved these changes
May 31, 2022
nfx
changed the title
databricks_mount for Google Storage
nfx
added a commit
that referenced
this pull request
Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)). * Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)). * Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)). * Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)). * Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)). * Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)). * Apply ownership for UC objects during creation ([#1338](#1338)). * Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)). * Various documentation fixes ([#1350](#1350)). Updated dependency versions: * Bump google.golang.org/api from 0.80.0 to 0.81.0 * Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6 * Bump google.golang.org/api from 0.81.0 to 0.82.0 * Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
Merged
nfx
added a commit
that referenced
this pull request
Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)). * Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)). * Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)). * Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)). * Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)). * Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)). * Apply ownership for UC objects during creation ([#1338](#1338)). * Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)). * Various documentation fixes ([#1350](#1350)). Updated dependency versions: * Bump google.golang.org/api from 0.80.0 to 0.81.0 * Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6 * Bump google.golang.org/api from 0.81.0 to 0.82.0 * Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
* Added `delta_sharing_*` support to `databricks_metastore` ([databricks#1334](databricks#1334)). * Added `databricks_git_credentials` pat discovery from common environment variables ([databricks#1353](databricks#1353)). * Added `databricks_permissions` for `databricks_pipeline` ([databricks#1361](databricks#1361)). * Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([databricks#1360](databricks#1360)). * Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([databricks#1354](databricks#1354)). * Update docs regarding importing of `databricks_sql_*` resources ([databricks#1349](databricks#1349)). * Apply ownership for UC objects during creation ([databricks#1338](databricks#1338)). * Re-create purged cluster for `databricks_mount` for Google Storage ([databricks#1333](databricks#1333)). * Various documentation fixes ([databricks#1350](databricks#1350)). Updated dependency versions: * Bump google.golang.org/api from 0.80.0 to 0.81.0 * Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6 * Bump google.golang.org/api from 0.81.0 to 0.82.0 * Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way if the cluster is deleted, it will be re-created.
This still leaves an issue where if the service account name changes, new cluster won't be created. You'd have to manually delete the mounting cluster so that new cluster is re-created with updated service account.
Hopefully resolves #1331.