Added databricks_service_principal and databricks_service_principals data resources
#1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
==========================================
+ Coverage 90.10% 90.14% +0.04%
==========================================
Files 122 124 +2
Lines 10127 10172 +45
==========================================
+ Hits 9125 9170 +45
Misses 638 638
Partials 364 364
|
nfx
requested changes
Jun 9, 2022
scim/data_service_principal.go
Outdated
| } | ||
| return common.DataResource(spnsData{}, func(ctx context.Context, e interface{}, c *common.DatabricksClient) error { | ||
| response := e.(*spnsData) | ||
| spnAPI := NewServicePrincipalsAPI(ctx, c) |
There was a problem hiding this comment.
this is useful for looking up spns either created outside of Terraform, or in another Terraform config - application_id or id are less friendly
| @@ -71,6 +75,7 @@ func DataSourceUser() *schema.Resource { | |||
| d.Set("home", fmt.Sprintf("/Users/%s", user.UserName)) | |||
| d.Set("repos", fmt.Sprintf("/Repos/%s", user.UserName)) | |||
| d.Set("external_id", user.ExternalID) | |||
| d.Set("application_id", user.ApplicationID) | |||
There was a problem hiding this comment.
if databricks_current_user is a Service Principal, return the application_id as well
nfx
changed the title
databricks_service_principal and databricks_service_principals data resources
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…ls` data resources (databricks#1370) * return `application_id` from `databricks_current_user` if that user is a Service Principal * add `databricks_service_principal` data source based on `application_id` * add `databricks_service_principals` data source based on `display_name` Co-authored-by: Ron DeFreitas <drax3d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues and closes #1207
application_idfromdatabricks_current_userif that user is a Service Principaldatabricks_service_principaldata source based onapplication_iddatabricks_service_principalsdata source based ondisplay_nameCloses [FEATURE] Add data source for SPNs and identify if current user is a SPN #1208