Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade uc api #1418

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Upgrade uc api #1418

merged 4 commits into from
Jul 4, 2022

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Jul 4, 2022

This closes #1394

alexott and others added 2 commits June 28, 2022 20:53
Otherwise, get following error when compiling:

```
vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:22: type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod)
vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:24: undeclared name: any (requires version go1.18 or later)
```
@nfx
Copy link
Contributor

nfx commented Jul 4, 2022

@nkvuong can you rebase it on master (go1.16) instead of fa5ba5d, as go 1.18 is not yet integrated into other builds.

@nfx nfx self-requested a review July 4, 2022 13:47
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, though please rebase on existing master, where we have go1.16 compiler - we don't have go1.18 installed on majority of machines yet

@nkvuong
Copy link
Contributor Author

nkvuong commented Jul 4, 2022

build are failing without go1.18 though, due to hashicorp/hcl/v2

@alexott
Copy link
Contributor

alexott commented Jul 4, 2022

@nkvuong I simply doesn't commit that change...

@codecov-commenter
Copy link

Codecov Report

Merging #1418 (5ef096d) into master (8f82a6e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1418   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         126      126           
  Lines       10189    10189           
=======================================
  Hits         9185     9185           
  Misses        640      640           
  Partials      364      364           
Impacted Files Coverage Δ
catalog/resource_catalog.go 100.00% <100.00%> (ø)
catalog/resource_external_location.go 100.00% <100.00%> (ø)
catalog/resource_grants.go 96.03% <100.00%> (ø)
catalog/resource_metastore.go 100.00% <100.00%> (ø)
catalog/resource_metastore_assignment.go 95.00% <100.00%> (ø)
catalog/resource_metastore_data_access.go 87.27% <100.00%> (ø)
catalog/resource_schema.go 100.00% <100.00%> (ø)
catalog/resource_storage_credential.go 100.00% <100.00%> (ø)
catalog/resource_table.go 100.00% <100.00%> (ø)
catalog/update.go 100.00% <100.00%> (ø)

@nfx nfx merged commit 5615f80 into master Jul 4, 2022
@nfx nfx deleted the upgrade-uc-api branch July 4, 2022 15:35
nkvuong added a commit that referenced this pull request Jul 7, 2022
@nfx nfx mentioned this pull request Jul 7, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Terraform should use the 2.1 API version for UC service calls
4 participants