-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade uc api #1418
Upgrade uc api #1418
Conversation
Otherwise, get following error when compiling: ``` vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:22: type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod) vendor/github.com/hashicorp/hcl/v2/diagnostic_typeparams.go:22:24: undeclared name: any (requires version go1.18 or later) ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good, though please rebase on existing master, where we have go1.16 compiler - we don't have go1.18 installed on majority of machines yet
build are failing without go1.18 though, due to hashicorp/hcl/v2 |
@nkvuong I simply doesn't commit that change... |
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 126 126
Lines 10189 10189
=======================================
Hits 9185 9185
Misses 640 640
Partials 364 364
|
This closes #1394