Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for databricks_azure_adls_gen1_mount #1461

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Remove tests for databricks_azure_adls_gen1_mount #1461

merged 4 commits into from
Jul 20, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jul 14, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #1461 (0fcc5a2) into master (c268c41) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1461   +/-   ##
=======================================
  Coverage   90.12%   90.13%           
=======================================
  Files         126      126           
  Lines       10221    10227    +6     
=======================================
+ Hits         9212     9218    +6     
  Misses        642      642           
  Partials      367      367
Impacted Files Coverage Δ
common/client.go 97.62% <ø> (ø)
common/azure_auth.go 92.05% <100.00%> (+0.21%) ⬆️
common/azure_cli_auth.go 90.74% <100.00%> (+0.35%) ⬆️

@nfx nfx marked this pull request as ready for review July 20, 2022 15:25
@nfx nfx enabled auto-merge (squash) July 20, 2022 15:25
@nfx nfx disabled auto-merge July 20, 2022 15:31
@nfx nfx merged commit 35c7856 into master Jul 20, 2022
@nfx nfx deleted the test-improve branch July 20, 2022 15:31
alexott
alexott approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx mentioned this pull request Jul 21, 2022
Merged
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
@nfx
Remove tests for databricks_azure_adls_gen1_mount (databricks#1461)
4029fd0 
* Remove tests for `databricks_azure_adls_gen1_mount`
* Renamed `TEST_AWS_ACCOUNT_ID` to `AWS_ACCOUNT_ID`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfx @codecov-commenter @alexott