Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for databricks_permissions and databricks_obo_token #1462

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

arpitjasa-db
Copy link
Contributor

Fixes #1223.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #1462 (e7a596e) into master (c268c41) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1462   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files         126      126           
  Lines       10221    10221           
=======================================
  Hits         9212     9212           
  Misses        642      642           
  Partials      367      367           

docs/index.md Outdated Show resolved Hide resolved
docs/resources/permissions.md Outdated Show resolved Hide resolved
docs/resources/permissions.md Outdated Show resolved Hide resolved
@@ -718,3 +730,26 @@ The resource permissions can be imported using the object id
```bash
$ terraform import databricks_permissions.this /<object type>/<object id>
```

### Import Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Import Example

merge with previous section.

please use https://registry.terraform.io/tools/doc-preview to preview changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks better as a subsection rather than just having it there. What do you think?

Subsection preview:
Screen Shot 2022-07-14 at 4 50 43 PM

Merged section preview:
Screen Shot 2022-07-14 at 4 54 29 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good. thank you for performing validation ;)

@arpitjasa-db arpitjasa-db requested a review from nfx July 14, 2022 23:56
@nfx nfx changed the title Fix Terraform docs for databricks_permissions and OBO tokens Improve docs for databricks_permissions and databricks_obo_token Jul 15, 2022
@nfx nfx merged commit 8064876 into databricks:master Jul 15, 2022
@nfx nfx mentioned this pull request Jul 15, 2022
@arpitjasa-db arpitjasa-db deleted the tf-fixes branch July 20, 2022 19:07
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
…atabricks#1462)

* Fix Terraform docs for databricks_permissions and OBO tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Fix Terraform docs for databricks_permissions and OBO tokens
3 participants