Change element type for cluster block to fix issue with phantom blocks in DLT pipeline #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current problem reported in #1401 is caused by the behaviour of the complex data types inside the blocks that use the `slice_set` as a type - when we make changes the phantom blocks are generated in addition to required changes. Adding a custom hash function didn't help. This PR attempts to fix that issue other way - by changing the type of `cluster` blocks from the `TypeSet` to the `TypeList`. This approach, besides fixing the original issue will also help with decreasing the amount of plan changes when making changes in the `cluster` block. The side effect of this change is that when upgrading to a new version, Terraform will show changes in the DLT pipeline resource even if no actual changes were made in the code - this is a result of changing the order of the `cluster` blocks
alexott
force-pushed
the
issue-1401-fix-2
branch
from
2fb896f
to
77762db
Compare
alexott
changed the title
nfx
approved these changes
Aug 2, 2022
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
) Current problem reported in databricks#1401 is caused by the behaviour of the complex data types inside the blocks that use the `slice_set` as a type - when we make changes the phantom blocks are generated in addition to required changes. Adding a custom hash function didn't help. This PR attempts to fix that issue other way - by changing the type of `cluster` blocks from the `TypeSet` to the `TypeList`. This approach, besides fixing the original issue will also help with decreasing the amount of plan changes when making changes in the `cluster` block. The side effect of this change is that when upgrading to a new version, Terraform will show changes in the DLT pipeline resource even if no actual changes were made in the code - this is a result of changing the order of the `cluster` blocks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem reported in #1401 is caused by the behaviour of the complex data types
inside the blocks that use the
slice_setas a type - when we make changes the phantomblocks are generated in addition to required changes. Adding a custom hash function
didn't help.
This PR attempts to fix that issue other way - by changing the type of
clusterblocksfrom the
TypeSetto theTypeList. This approach, besides fixing the original issuewill also help with decreasing the amount of plan changes when making changes in the
clusterblock.The side effect of this change is that when upgrading to a new version, Terraform will
show changes in the DLT pipeline resource even if no actual changes were made in the code -
this is a result of changing the order of the
clusterblocks