Added `databricks_provider` resource for Delta Sharing #1572

stikkireddy · 2022-08-30T14:55:16Z

Examples:

resource "databricks_provider" "dbprovider" {
  name = "sri-terraform-test-provider"
  comment = "made by terraform 2"
  authentication_type = "TOKEN"
  recipient_profile_str = jsonencode(
    {
        "shareCredentialsVersion":1,
        "bearerToken":"token",
        "endpoint":"endpoint",
        "expirationTime":"expiration-time"})
    }
  )
}```

… providers.

nfx

Plus: Missing acceptance test

catalog/resource_provider.go

docs/resources/provider.md

nfx · 2022-11-14T15:55:00Z

@stikkireddy what's the update on this PR?

…tabricks into delta-sharing/provider-resource � Conflicts: � provider/provider.go

codecov-commenter · 2022-12-22T16:16:52Z

Codecov Report

Merging #1572 (6b6ab56) into master (76bdecc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1572      +/-   ##
==========================================
+ Coverage   90.14%   90.17%   +0.03%     
==========================================
  Files         142      143       +1     
  Lines       11386    11423      +37     
==========================================
+ Hits        10264    10301      +37     
  Misses        712      712              
  Partials      410      410

Impacted Files	Coverage Δ
catalog/resource_provider.go	`100.00% <100.00%> (ø)`
provider/provider.go	`95.48% <100.00%> (+0.02%)`	⬆️

nfx

merge pending the acceptance test suite run on wednesday

# Version changelog ### 1.8.0 * Added support for GCP (Public Preview) with state upgraders for [databricks_mws_workspaces](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_workspaces) ([#1871](#1871), [#1886](#1886), [#1748](#1748), [#1879](#1879)). * Added documentation for [databricks_permission_assignment](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/permission_assignment) ([#1880](#1880)). * Added `azure_attributes` to clusters in [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1854](#1854)). * Added [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/instance_pool) data source ([#1907](#1907)). * Added [databricks_provider](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/provider) resource for Delta Sharing ([#1572](#1572)). * Added acceptance tests for [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/cluster) data and [databricks_sql_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/sql_endpoint) data ([#1882](#1882)). * Added search by name for [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/cluster) data source ([#1901](#1901)). * Added support for sparse checkouts in the [databricks_repo](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/repo) ([#1869](#1869)). * Added `config_reference` attribute to [databricks_secret](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/secret) for easier reference from Spark configuration ([#1898](#1898)). * Added `datarbicks_directory` data source ([#1902](#1902)). * Extended [databricks_catalog](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/catalog) resource to support Delta Sharing Catalog ([#1887](#1887)). * Improved [databricks_metastore_assignment](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/metastore_assignment) resource ([#1900](#1900)). * Improved [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) error messages ([#1888](#1888)). * Improved [databricks_group](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/group) documentation ([#1816](#1816)). * Improved `data_security_mode` documentation for [databricks_cluster](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/cluster) ([#1830](#1830)). * Replace the incorrect `id` attribute with the correct `sp_id` in service principal data source docs example ([#1873](#1873)). * Use NVMe disk size for selection in the [databricks_node_type](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/node_type) data source ([#1856](#1856)). * Allowed to override resource ID for specific data source ([#1885](#1885)). Experimental Resource Exporter * Added command-line flag to export all users and service principals ([#1893](#1893)). * Added emit for secret scopes from Spark Conf and Env Vars ([#1897](#1897)). * Fixed issue with exporting of resources with simple name ([#1891](#1891)). * Generate references that are matching only to a prefix ([#1890](#1890)). * Updated list of supported services and associated resources ([#1894](#1894)). * Use [databricks_group_role](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/group_role) instead of deprecated [databricks_group_instance_profile](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/group_instance_profile) ([#1905](#1905)). * Use `dbfs_path` as reference for init scripts in clusters ([#1892](#1892)). * Logging improvements ([#1895](#1895)). Updated dependency versions: * Bump google.golang.org/api from 0.104.0 to 0.105.0 ([#1863](#1863)).

initial commit for terraform delta sharing resource for delta sharing…

7d0af96

… providers.

stikkireddy requested a review from nfx August 30, 2022 14:55

stikkireddy added 2 commits August 30, 2022 10:55

fix example in docs

0633a3e

fixed linting error

c96e841

nfx requested changes Oct 13, 2022

View reviewed changes

nfx self-assigned this Oct 13, 2022

Merge branch 'master' of github.com:stikkireddy/terraform-provider-da…

52f286a

…tabricks into delta-sharing/provider-resource � Conflicts: � provider/provider.go

added acceptance test and made suggested changes

a65c402

stikkireddy requested a review from nfx December 22, 2022 20:26

nfx approved these changes Dec 26, 2022

View reviewed changes

Merge branch 'master' into delta-sharing/provider-resource

6b6ab56

nfx changed the title ~~Delta sharing provider resource~~ Added databricks_provider resource for Delta Sharing Dec 26, 2022

nfx merged commit 6567510 into databricks:master Dec 26, 2022

nfx mentioned this pull request Jan 10, 2023

Release v1.8.0 #1915

Merged

michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023

Added databricks_provider resource for Delta Sharing (databricks#1572)

b907bd7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added `databricks_provider` resource for Delta Sharing #1572

Added `databricks_provider` resource for Delta Sharing #1572

stikkireddy commented Aug 30, 2022

nfx left a comment

nfx commented Nov 14, 2022

codecov-commenter commented Dec 22, 2022 •

edited

Loading

nfx left a comment

Added databricks_provider resource for Delta Sharing #1572

Added databricks_provider resource for Delta Sharing #1572

Conversation

stikkireddy commented Aug 30, 2022

nfx left a comment

Choose a reason for hiding this comment

nfx commented Nov 14, 2022

codecov-commenter commented Dec 22, 2022 • edited Loading

Codecov Report

nfx left a comment

Choose a reason for hiding this comment

Added `databricks_provider` resource for Delta Sharing #1572

Added `databricks_provider` resource for Delta Sharing #1572

codecov-commenter commented Dec 22, 2022 •

edited

Loading