Correct exporting of the computed attributes for databricks_cluster
#1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1711 +/- ##
==========================================
+ Coverage 89.99% 90.03% +0.04%
==========================================
Files 141 141
Lines 11079 11151 +72
==========================================
+ Hits 9970 10040 +70
- Misses 707 709 +2
Partials 402 402
|
alexott
force-pushed
the
exporter-node-type-id-support
branch
2 times, most recently
from
415c7f2
to
0c04b82
Compare
alexott
force-pushed
the
exporter-node-type-id-support
branch
from
66bbfc0
to
8ec02b1
Compare
nfx
requested changes
Nov 4, 2022
exporter/util.go
Outdated
| } | ||
| } | ||
| raw := d.Get(pathString) | ||
| // log.Printf("[DEBUG] path=%s, raw='%v'", pathString, raw) |
move part of implementation into the utils
alexott
force-pushed
the
exporter-node-type-id-support
branch
from
8ec02b1
to
e72d4cf
Compare
|
@nfx code is cleaned up |
nfx
approved these changes
Nov 4, 2022
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some attributes, such as
node_type_idare marked ascomputedand not exported by default. This PR adds a resource-level function that will decide if the resource field needs to be omitted or kept. This function is applied to all fields, not only to computed, so we can avoid exporting defaults, etc.This fixes #1613