Fix missing attributes from databricks_job data source
#1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
requested changes
Nov 25, 2022
jobs/data_job.go
Outdated
| } else { | ||
| // if name is not provided, need to list all the jobs and search by id | ||
| // does not expand tasks to limit the results size | ||
| list, err = jobsAPI.List() |
There was a problem hiding this comment.
If we have a job ID, then why not simply call Read using that ID? It will be more efficient :-)
There was a problem hiding this comment.
this is a lot simpler now
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
+ Coverage 89.71% 90.02% +0.30%
==========================================
Files 142 142
Lines 11222 11227 +5
==========================================
+ Hits 10068 10107 +39
+ Misses 743 712 -31
+ Partials 411 408 -3
|
alexott
approved these changes
Nov 25, 2022
nkvuong
force-pushed
the
fix/job_data_missing_attributes
branch
from
23345e2
to
634a2e1
Compare
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
…1798) * re-add expand_tasks to retrieve settings * fix error messages * simplify read by Id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because we did not set expandTasks to the API when listing the jobs. For search by id, list without expandTasks and then re-search when job name is found
This closes #1797