Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter for databricks_sql_global_config resource #1806

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 1, 2022

This fixes #1640

@alexott alexott requested review from nfx and a team December 1, 2022 09:43
@codecov-commenter
Copy link

Codecov Report

Merging #1806 (e1a961d) into master (4a7ca53) will increase coverage by 0.21%.
The diff coverage is 78.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
+ Coverage   89.71%   89.92%   +0.21%     
==========================================
  Files         142      142              
  Lines       11222    11271      +49     
==========================================
+ Hits        10068    10136      +68     
+ Misses        743      725      -18     
+ Partials      411      410       -1     
Impacted Files Coverage Δ
workspace/resource_notebook.go 88.97% <ø> (ø)
exporter/importables.go 89.27% <71.84%> (+1.84%) ⬆️
exporter/util.go 84.40% <72.00%> (+2.71%) ⬆️
exporter/context.go 85.90% <100.00%> (+0.03%) ⬆️
sql/api/query.go 75.40% <100.00%> (+2.14%) ⬆️
sql/resource_sql_global_config.go 85.18% <100.00%> (ø)
sql/resource_sql_query.go 95.77% <100.00%> (+0.18%) ⬆️

@rohitnijhawan
Copy link
Contributor

@alexott Can I please get a review?

@alexott
Copy link
Contributor Author

alexott commented Dec 1, 2022

just start review...

@nfx nfx merged commit da583cd into master Dec 2, 2022
@nfx nfx deleted the sql_global_config-exporter branch December 2, 2022 10:06
@nfx nfx mentioned this pull request Dec 14, 2022
@alexott alexott added the exporter TF configuration generator label Jan 5, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] databricks_sql_global_config isn't exported
4 participants