Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UC support on GCP as gcp_service_account_key #1836

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Add UC support on GCP as gcp_service_account_key #1836

merged 4 commits into from
Dec 14, 2022

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Dec 12, 2022

This adds gcp_service_account_key as a block in databricks_storage_credential and databricks_metastore_data_access, to support Unity Catalog private preview on GCP

@codecov-commenter
Copy link

Codecov Report

Merging #1836 (51d0ef4) into master (d4915dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   90.14%   90.15%           
=======================================
  Files         142      142           
  Lines       11358    11363    +5     
=======================================
+ Hits        10239    10244    +5     
  Misses        711      711           
  Partials      408      408           
Impacted Files Coverage Δ
catalog/resource_metastore_data_access.go 87.71% <100.00%> (+0.44%) ⬆️
catalog/resource_storage_credential.go 100.00% <100.00%> (ø)
catalog/update.go 100.00% <100.00%> (ø)
exporter/context.go 87.53% <100.00%> (ø)
policies/data_cluster_policy.go 92.00% <100.00%> (+2.00%) ⬆️

@nkvuong nkvuong requested a review from nfx December 13, 2022 12:24
@nfx nfx enabled auto-merge (squash) December 14, 2022 13:14
@nfx nfx merged commit e9bcc2d into master Dec 14, 2022
@nfx nfx mentioned this pull request Dec 14, 2022
@nkvuong nkvuong deleted the feature/gcp-uc branch January 4, 2023 12:30
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
* Add UC support on GCP

* fix tests

* fix DiffSuprressFunc
@aucampia
Copy link

Not sure why this removed docs/resources/table.md but it seems it should not have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants