Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document webhook_notifications for databricks_job resource #1842

Merged
merged 6 commits into from
Dec 14, 2022

Conversation

akolar-db
Copy link
Contributor

@akolar-db akolar-db commented Dec 13, 2022

Document webhook_notifications field. Webhooks are configured in TF as follows:

webhook_notifications {
	on_start {
		id = "id3"
	}
	on_start {
		id = "id1"
	}
	on_start {
		id = "id2"
	}
	on_success {
		id = "id2"
	}
	on_failure {
		id = "id3"
	}
}

OpenAPI spec added here.

@akolar-db akolar-db changed the title Document webhook_notifications field [JOBS-9951] Document webhook_notifications field Dec 13, 2022

### webhook Confiuration Block

* `id` - ID of the destination that is notified when an event defined in `webhook_notifications` is triggered.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a discrepancy in terminology - here the destination word is used, and in other places: system notification ID - it's better to standartize

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, ty!

@codecov-commenter
Copy link

Codecov Report

Merging #1842 (45c73ce) into master (d4915dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1842   +/-   ##
=======================================
  Coverage   90.14%   90.15%           
=======================================
  Files         142      142           
  Lines       11358    11363    +5     
=======================================
+ Hits        10239    10244    +5     
  Misses        711      711           
  Partials      408      408           
Impacted Files Coverage Δ
exporter/context.go 87.53% <100.00%> (ø)
policies/data_cluster_policy.go 92.00% <100.00%> (+2.00%) ⬆️

@nfx nfx changed the title [JOBS-9951] Document webhook_notifications field Document webhook_notifications for databricks_job resource Dec 14, 2022
@nfx nfx merged commit 87dce34 into databricks:master Dec 14, 2022
@nfx nfx mentioned this pull request Dec 14, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants