Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore network diff for GCP workspaces with DB-managed VPC #1847

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Ignore network diff for GCP workspaces with DB-managed VPC #1847

merged 4 commits into from
Dec 14, 2022

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Dec 13, 2022

Close #1807

alexott
alexott reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm code-wise, but maybe it would be easier to ignore network part on the Read if network isn't configured in the state?

@nkvuong nkvuong changed the title suppress network diff for GCP workspaces Ignore network diff for GCP workspaces with DB-managed VPC Dec 14, 2022
alexott
alexott approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx enabled auto-merge (squash) December 14, 2022 13:16
@codecov-commenter
Copy link

Codecov Report

Merging #1847 (1e6d02d) into master (87dce34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1847   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         142      142           
  Lines       11363    11370    +7     
=======================================
+ Hits        10244    10251    +7     
  Misses        711      711           
  Partials      408      408
Impacted Files Coverage Δ
mws/resource_mws_workspaces.go 90.64% <100.00%> (+0.24%) ⬆️

@nfx nfx merged commit d7629d5 into master Dec 14, 2022
@nfx nfx mentioned this pull request Dec 14, 2022
Merged
@nkvuong nkvuong deleted the fix/gcp_network_suppress_diff branch January 4, 2023 12:30
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
@nkvuong
Ignore network diff for GCP workspaces with DB-managed VPC (databri…
974b0aa 
…cks#1847)

* suppress `network` diff for GCP workspaces
* null out reads instead of suppress diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Terraform provider keeps re-creating GCP workspace
4 participants
@nkvuong @codecov-commenter @alexott @nfx