Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed databricks_cluster resource missing library definitions issues #1925

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Fixed databricks_cluster resource missing library definitions issues #1925

merged 3 commits into from
Jan 23, 2023

Conversation

ukannikanti
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2023 •
edited
Loading

Codecov Report

Merging #1925 (f7955fc) into master (f2f53c8) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
+ Coverage   90.15%   90.21%   +0.06%     
==========================================
  Files         145      146       +1     
  Lines       11829    11861      +32     
==========================================
+ Hits        10664    10700      +36     
+ Misses        752      748       -4     
  Partials      413      413
Impacted Files Coverage Δ
clusters/resource_library.go 84.84% <100.00%> (+0.47%) ⬆️
exporter/importables.go 90.22% <100.00%> (+0.03%) ⬆️
exporter/util.go 88.51% <100.00%> (+0.48%) ⬆️
libraries/libraries_api.go 94.90% <100.00%> (+0.03%) ⬆️
clusters/clusters_api.go 85.71% <0.00%> (ø)
mws/data_mws_credentials.go 100.00% <0.00%> (ø)
provider/provider.go 95.56% <0.00%> (+0.02%) ⬆️
access/resource_sql_permissions.go 86.11% <0.00%> (+0.06%) ⬆️
mws/resource_mws_credentials.go 92.00% <0.00%> (+8.00%) ⬆️

alexott
alexott requested changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes are required to prevent decrease in code coverage...

Also, check that all code in importables.go and utils.go is covered by tests - not only "happy path" but also error handling

libraries/libraries_api.go Show resolved Hide resolved
alexott
alexott approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it looks good...

@nfx nfx changed the title Fix databricks_cluster resource missing Library definitions issues Fixed databricks_cluster resource missing library definitions issues Jan 23, 2023
@nfx nfx enabled auto-merge (squash) January 23, 2023 15:43
@nfx nfx merged commit 76197f2 into databricks:master Jan 23, 2023
@nfx nfx mentioned this pull request Jan 25, 2023
Merged
@rohitnijhawan rohitnijhawan mentioned this pull request Jan 31, 2023
Closed
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
@ukannikanti
Fixed databricks_cluster resource missing library definitions issues (
eb0bb3e 
databricks#1925)

* Fix databricks_cluster resource missing Library definitions issues
* Added unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ukannikanti @codecov-commenter @alexott @nfx @umakann-db