Add description to max_clusters_per_user in policies schema. Re-format docs.
#1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `make fmt-docs`.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1959 +/- ##
==========================================
+ Coverage 90.24% 90.29% +0.05%
==========================================
Files 146 146
Lines 11898 11906 +8
==========================================
+ Hits 10737 10751 +14
+ Misses 749 746 -3
+ Partials 412 409 -3
|
alexott
requested changes
Jan 26, 2023
docs/resources/cluster_policy.md
Outdated
| @@ -99,7 +99,7 @@ The following arguments are required: | |||
|
|
|||
| * `name` - (Required) Cluster policy name. This must be unique. Length must be between 1 and 100 characters. | |||
| * `definition` - (Required) Policy definition: JSON document expressed in [Databricks Policy Definition Language](https://docs.databricks.com/administration-guide/clusters/policies.html#cluster-policy-definition). | |||
| * `max_clusters_per_user` - (Optional, integer) Maximum number of clusters allowed per user. When omitted, there is no limit. | |||
| * `max_clusters_per_user` - (Optional, integer) Maximum number of clusters allowed per user. When omitted, there is no limit. If specified, value must be non-zero. | |||
There was a problem hiding this comment.
it's better to say "greater than zero" :-)
| @@ -125,6 +125,9 @@ func ResourceClusterPolicy() *schema.Resource { | |||
| "max_clusters_per_user": { | |||
| Type: schema.TypeInt, | |||
| Optional: true, | |||
| Description: "Max number of clusters per user that can be active\n" + | |||
| "using this policy. If not present, there is no max limit.", | |||
| ValidateFunc: validation.IntAtLeast(1), | |||
There was a problem hiding this comment.
does it work when omitted?
There was a problem hiding this comment.
Yes, I've tested it with and without the parameter.
nfx
approved these changes
Jan 27, 2023
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.