Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start_version and cdf_enabled support for databricks_share #2007

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Add start_version and cdf_enabled support for databricks_share #2007

merged 4 commits into from
Feb 16, 2023

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Feb 15, 2023

Closes #2004

Also fix diff detection, closes #2003

@nkvuong nkvuong changed the title Add history_data_sharing_status and cdf_enabled support for databricks_share Add start_version and cdf_enabled support for databricks_share Feb 15, 2023
@nkvuong nkvuong marked this pull request as ready for review February 15, 2023 19:00
@nkvuong
Copy link
Contributor Author

nkvuong commented Feb 15, 2023

acceptance tests also passed

@nkvuong nkvuong requested review from a team February 15, 2023 19:01
alexott
alexott approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. The only a bit of worry that upgrade from slice_set to slice may lead to user's confusion, but that could be ok - we had similar thing DLT pipelines.

@marekbrysa
Copy link
Contributor

@nkvuong thanks for the quick implementation!
I don't think this should close #2004 because AFAICT it does not implement history_data_sharing_status? Or would it be better to split the issue?

@nkvuong
Copy link
Contributor Author

nkvuong commented Feb 16, 2023

@marekbrysa I missed that one, as history_data_sharing_status was not in the API doc - let me quickly add it to this PR and test it

@nfx nfx merged commit dc40d34 into master Feb 16, 2023
@nfx nfx deleted the delta-sharing-share branch February 16, 2023 10:25
@marekbrysa marekbrysa mentioned this pull request Feb 16, 2023
Closed
@nfx nfx mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nkvuong @marekbrysa @alexott @nfx