Added support for Unity Catalog databricks_metastores data source

catalog/data_metastores.go

@@ -0,0 +1,22 @@
+package catalog
+
+import (
+	"context"
+
+	"github.com/databricks/databricks-sdk-go"
+	"github.com/databricks/terraform-provider-databricks/common"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func DataSourceMetastores() *schema.Resource {
+	return common.AccountData(func(ctx context.Context, data *MetastoresData, acc *databricks.AccountClient) error {
+		metastores, err := acc.Metastores.List(ctx)
+		if err != nil {
+			return err
+		}
+		for _, v := range metastores.Metastores {
+			data.Ids = append(data.Ids, v.MetastoreId)
+		}
+		return nil
+	})
+}

catalog/data_metastores_test.go

@@ -0,0 +1,92 @@
+package catalog
+
+import (
+	"testing"
+
+	"github.com/databricks/databricks-sdk-go/service/catalog"
+	"github.com/databricks/terraform-provider-databricks/qa"
+)
+
+func TestMetastoresData(t *testing.T) {
+	qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			{
+				Method:   "GET",
+				Resource: "/api/2.0/accounts/testaccount/metastores",
+				Response: catalog.ListMetastoresResponse{
+					Metastores: []catalog.MetastoreInfo{
+						{
+							Name:                      "a",
+							StorageRoot:               "",
+							DefaultDataAccessConfigId: "sth",
+							Owner:                     "John.Doe@example.com",
+							MetastoreId:               "abc",
+							Region:                    "",
+							Cloud:                     "",
+							GlobalMetastoreId:         "",
+							CreatedAt:                 0,
+							CreatedBy:                 "",
+							UpdatedAt:                 0,
+							UpdatedBy:                 "",
+							DeltaSharingScope:         "",
+							DeltaSharingRecipientTokenLifetimeInSeconds: 0,
+							DeltaSharingOrganizationName:                "",
+						},
+					},
+				},
+			},
+		},
+		Resource:    DataSourceMetastores(),
+		Read:        true,
+		NonWritable: true,
+		ID:          "_",
+		AccountID:   "testaccount",
+	}.ApplyNoError(t)
+}
+
+func TestMetastoresDataContainsName(t *testing.T) {
+	qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			{
+				Method:   "GET",
+				Resource: "/api/2.0/accounts/testaccount/metastores",
+				Response: catalog.ListMetastoresResponse{
+					Metastores: []catalog.MetastoreInfo{
+						{
+							Name:                      "a",
+							StorageRoot:               "abc",
+							DefaultDataAccessConfigId: "sth",
+							Owner:                     "John.Doe@example.com",
+							MetastoreId:               "abc",
+						},
+						{
+							Name:                      "b",
+							StorageRoot:               "dcw",
+							DefaultDataAccessConfigId: "sth",
+							Owner:                     "John.Doe@example.com",
+							MetastoreId:               "ded",
+						},
+					},
+				},
+			},
+		},
+		Resource:    DataSourceMetastores(),
+		Read:        true,
+		NonWritable: true,
+		ID:          "_",
+		AccountID:   "testaccount",
+	}.ApplyAndExpectData(t, map[string]any{
+		"ids": []string{"abc", "ded"},
+	})
+}
+
+func TestMetastoresData_Error(t *testing.T) {
+	qa.ResourceFixture{
+		Fixtures:    qa.HTTPFailures,
+		Resource:    DataSourceMetastores(),
+		Read:        true,
+		NonWritable: true,
+		ID:          "_",
+		AccountID:   "_",
+	}.ExpectError(t, "I'm a teapot")
+}

catalog/resource_metastore.go

@@ -38,16 +38,15 @@ type MetastoreInfo struct {
 	DeltaSharingOrganizationName                string  `json:"delta_sharing_organization_name,omitempty"`
 }
 
+type MetastoresData struct {
+	Ids []string `json:"ids,omitempty" tf:"computed,slice_set"`
+}
+
 type CreateMetastore struct {
 	Name        string `json:"name"`
 	StorageRoot string `json:"storage_root"`
 }
 
-// func (a MetastoresAPI) listMetastores() (mis []MetastoreInfo, err error) {
-// 	err = a.client.Get(a.context, "/unity-catalog/metastores", nil, &mis)
-// 	return
-// }
-
 func (a MetastoresAPI) createMetastore(cm CreateMetastore) (mi MetastoreInfo, err error) {
 	err = a.client.Post(a.context, "/unity-catalog/metastores", cm, &mi)
 	return

docs/data-sources/metastores.md

@@ -0,0 +1,33 @@
+---
+subcategory: "Unity Catalog"
+---
+# databricks_metastores Data Source
+
+-> **Note** If you have a fully automated setup with workspaces created by [databricks_mws_workspaces](../resources/mws_workspaces.md) or [azurerm_databricks_workspace](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/databricks_workspace), please make sure to add [depends_on attribute](../index.md#data-resources-and-authentication-is-not-configured-errors) in order to prevent _authentication is not configured for provider_ errors.
+
+Retrieves a list of ids of [databricks_metastore](../resources/metastore.md) objects, that were created by Terraform or manually, so that special handling could be applied.
+
+## Example Usage
+
+Listing ids of all catalogs:
+
+```hcl
+data "databricks_metastores" "all" {}
+
+output "all_metastores" {
+  value = data.databricks_metastores.all
+}
+```
+
+## Attribute Reference
+
+This data source exports the following attributes:
+
+* `metastores` - list of ids of [databricks_metastore](../resources/metastore.md)
+
+## Related Resources
+
+The following resources are used in the same context:
+
+* [databricks_metastore](../resources/metastore.md) to manage Metastores within Unity Catalog.
+* [databricks_catalog](../resources/catalog.md) to manage catalogs within Unity Catalog.

internal/acceptance/data_metastores_test.go

@@ -0,0 +1,16 @@
+package acceptance
+
+import (
+	"testing"
+)
+
+func TestUcAccDataSourceMetastore(t *testing.T) {
+	accountLevel(t, step{
+		Template: `
+		data "databricks_metastores" "this" {}
+
+		output "all_metastores" {
+			value = data.databricks_metastores.this
+		}`,
+	})
+}

provider/provider.go

@@ -62,6 +62,7 @@ func DatabricksProvider() *schema.Provider {
 			"databricks_instance_pool":           pools.DataSourceInstancePool(),
 			"databricks_jobs":                    jobs.DataSourceJobs(),
 			"databricks_job":                     jobs.DataSourceJob(),
+			"databricks_metastores":              catalog.DataSourceMetastores(),
 			"databricks_mws_credentials":         mws.DataSourceMwsCredentials(),
 			"databricks_mws_workspaces":          mws.DataSourceMwsWorkspaces(),
 			"databricks_node_type":               clusters.DataSourceNodeType(),