Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix databricks_share update logic #2022

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fix databricks_share update logic #2022

merged 3 commits into from
Feb 21, 2023

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Feb 20, 2023

Current logic only sends update if a new share name is added/removed.

This PR compares the properties of a share and send the appropriate update payload as well

@nkvuong
Copy link
Contributor Author

nkvuong commented Feb 20, 2023

acceptance tests passed

@nkvuong nkvuong marked this pull request as ready for review February 20, 2023 13:10
@nkvuong nkvuong requested review from a team February 20, 2023 13:11
@codecov-commenter
Copy link

Codecov Report

Merging #2022 (b8b86a2) into master (9cac76d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2022   +/-   ##
=======================================
  Coverage   89.51%   89.52%           
=======================================
  Files         140      140           
  Lines       11039    11043    +4     
=======================================
+ Hits         9882     9886    +4     
  Misses        767      767           
  Partials      390      390           
Impacted Files Coverage Δ
catalog/resource_share.go 95.12% <100.00%> (+0.25%) ⬆️

@nfx nfx enabled auto-merge (squash) February 21, 2023 10:32
@nfx nfx merged commit cf91f32 into master Feb 21, 2023
@nfx nfx mentioned this pull request Feb 21, 2023
@nkvuong nkvuong deleted the fix/delta-sharing-update branch April 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants