resource_workspace_conf Delete: only reset enable and enforce properties #2025
Conversation
| @@ -104,6 +104,11 @@ func ResourceWorkspaceConf() *schema.Resource { | |||
| Delete: func(ctx context.Context, d *schema.ResourceData, c *common.DatabricksClient) error { | |||
| config := d.Get("custom_config").(map[string]any) | |||
| for k, v := range config { | |||
| if !strings.HasPrefix(k, "enable") && !strings.HasPrefix(k, "enforce") { | |||
There was a problem hiding this comment.
Really it's not ideal situation as the workspace isn't returned to the original state. One approach would be to collect original values on create/update, and then reset to that values on delete.
There was a problem hiding this comment.
I get your point, for example the projectsAllowList (allowed git url's) is something you would like to reset (""), with the companion setting: projectsAllowListPermissions : "ALL_REPOS" (default).
Is there a way how to fetch or store the default values?
There was a problem hiding this comment.
yes. something similar.
You can retrieve original values when creating/updating a resource and store original values in a computed property (for example as JSON string, or something like)
There was a problem hiding this comment.
a simpler solution could be to do nothing. Delete just removes the resource from backend / state. (This follows others work arounds now) The logic here would be that we are asking for the lack of management over the resource. As we know, we can't actually delete the workspace conf. All workspaces start with a configuration, even if its default. To get a default configuration, a simple inclusion of a workspace_conf with default settings. That to me IS a configuration. Its all grey but i fall into the camp that
is asking for no more management not default setup.
|
Resolved by #3737 |
Make the code aligned with the documentation: https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_conf#argument-reference
PR for Issue: #1802 (remove a workspace with a non-enable/enforce setting)