Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port databricks_node_type data source to Go SDK #2070

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Mar 6, 2023

Please note that we can't use WorkspaceData here because we need to provide a request as schema, and we can't inherit from it.

@alexott alexott requested review from a team March 6, 2023 13:26
@alexott alexott marked this pull request as ready for review March 6, 2023 13:50
@alexott
Copy link
Contributor Author

alexott commented Mar 6, 2023

Acceptance tests on all clouds are passed

@nfx
Copy link
Contributor

nfx commented Mar 8, 2023

@alexott updated SDK with the id change you've pushed

Please note that we can't use `WorkspaceData` here because we need to provide a request as
schema, and we can't inherit from it.
@alexott
Copy link
Contributor Author

alexott commented Mar 8, 2023

@nfx it's ready

@alexott
Copy link
Contributor Author

alexott commented Mar 8, 2023

Hmmm, acceptance tests are failing

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@nfx
Copy link
Contributor

nfx commented Mar 8, 2023

integration tests passed

@nfx nfx merged commit 27c64b9 into master Mar 8, 2023
@nfx nfx deleted the node-type-go-sdk branch March 8, 2023 19:03
nfx added a commit that referenced this pull request Mar 9, 2023
* Added databricks_model_serving resource (#2054).
* Added Unity Catalog on GCP support (#2000).
* Deprecate schedule block in databricks_sql_query resource (#2078).
* Fixed InitScripts Type to work with GCS and ABFS in databricks_cluster resource (#2067).
* Added more testing for databricks_tables data source (#2075).
* Added more testing for databricks_schemas data source (#2074).
* Migrate databricks_node_type data source to Go SDK (#2070).
* Migrate databricks_schemas data to Go SDK (#2065).
* Migrate databricks_tables data source to SDK (#2068).
* Migrate databricks_views data source to Go SDK (#2073).
* Migrated databricks_git_credential to Go SDK (#2069).
* Migrated databricks_shares data source to Go SDK (#2072).

Updated dependency versions:

* Bump github.com/databricks/databricks-sdk-go from v0.3.3 to v0.4.0 (#2086).
* Bump golang.org/x/mod from 0.8.0 to 0.9.0 (#2076).
@nfx nfx mentioned this pull request Mar 9, 2023
nfx added a commit that referenced this pull request Mar 9, 2023
* Added databricks_model_serving resource (#2054).
* Added Unity Catalog on GCP support (#2000).
* Deprecate schedule block in databricks_sql_query resource (#2078).
* Fixed InitScripts Type to work with GCS and ABFS in databricks_cluster resource (#2067).
* Added more testing for databricks_tables data source (#2075).
* Added more testing for databricks_schemas data source (#2074).
* Migrate databricks_node_type data source to Go SDK (#2070).
* Migrate databricks_schemas data to Go SDK (#2065).
* Migrate databricks_tables data source to SDK (#2068).
* Migrate databricks_views data source to Go SDK (#2073).
* Migrated databricks_git_credential to Go SDK (#2069).
* Migrated databricks_shares data source to Go SDK (#2072).

Updated dependency versions:

* Bump github.com/databricks/databricks-sdk-go from v0.3.3 to v0.4.0 (#2086).
* Bump golang.org/x/mod from 0.8.0 to 0.9.0 (#2076).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants