Document enable_serverless_compute API changes in databricks_sql_endpoint resource
#2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay "SQL warehouse" which is Databricks current name for them.
…these types of cases
…space" since we don't do that as of GA). Azure doesn't need special terms of use flags at account level : ``` If your account was created before October 1, 2021, your organization's owner or account administrator must [accept applicable terms of use](https://docs.databricks.com/sql/admin/serverless.html#accept-terms) before workspaces are enabled for serverless compute. A workspace must meet the [requirements](https://docs.databricks.com/sql/admin/serverless.html#requirements) and might require an update its instance profile role to [add a trust relationship](https://docs.databricks.com/sql/admin/serverless.html#aws-instance-profile-setup). For Azure, you must [enable your workspace for serverless SQL warehouse](https://learn.microsoft.com/azure/databricks/sql/admin/serverless). ```
…ccount level" as part of GA ``` For AWS, Databricks strongly recommends that you always explicitly set this field. If omitted, the default is false for most workspaces. However, if this workspace used the SQL Warehouses API to create a warehouse between September 1, 2022 and April 6, 2023, the default remains the previous behavior which is default to true if the workspace is enabled for serverless and fits the requirements for serverless SQL warehouses. To avoid ambiguity, especially for organizations with many workspaces, Databricks recommends that you always set this field. ```
…apitalization (though I wasn't sure about article "Data Source" whether that needs to remain, so I left it be)
…SQL warehouses are disabled for the workspace, the default is `false`. If serverless SQL warehouses are enabled for the workspace, the default is `true`.
|
please rebase onto the latest |
…ay "SQL warehouse" which is Databricks current name for them.
…these types of cases
…space" since we don't do that as of GA). Azure doesn't need special terms of use flags at account level : ``` If your account was created before October 1, 2021, your organization's owner or account administrator must [accept applicable terms of use](https://docs.databricks.com/sql/admin/serverless.html#accept-terms) before workspaces are enabled for serverless compute. A workspace must meet the [requirements](https://docs.databricks.com/sql/admin/serverless.html#requirements) and might require an update its instance profile role to [add a trust relationship](https://docs.databricks.com/sql/admin/serverless.html#aws-instance-profile-setup). For Azure, you must [enable your workspace for serverless SQL warehouse](https://learn.microsoft.com/azure/databricks/sql/admin/serverless). ```
…ccount level" as part of GA ``` For AWS, Databricks strongly recommends that you always explicitly set this field. If omitted, the default is false for most workspaces. However, if this workspace used the SQL Warehouses API to create a warehouse between September 1, 2022 and April 6, 2023, the default remains the previous behavior which is default to true if the workspace is enabled for serverless and fits the requirements for serverless SQL warehouses. To avoid ambiguity, especially for organizations with many workspaces, Databricks recommends that you always set this field. ```
…apitalization (though I wasn't sure about article "Data Source" whether that needs to remain, so I left it be)
…SQL warehouses are disabled for the workspace, the default is `false`. If serverless SQL warehouses are enabled for the workspace, the default is `true`.
…tps://github.com/jxbell/terraform-provider-databricks into terraform-aws-serverless-sql-api-change-DOC-6788
|
@alexott , ok I just pulled origin/master into my fork master, did merge master to my branch, and then did "git rebase master" |
|
@alexott It appears to still fail that "fail on differences" step |
…IN TO NOT REMOVE THE GLOBAL CONFIG FIELDS
alexott
requested changes
Mar 21, 2023
jxbell
commented
Mar 21, 2023
jxbell
commented
Mar 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2137 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 137 137
Lines 11196 11198 +2
=======================================
+ Hits 9968 9970 +2
Misses 823 823
Partials 405 405 |
jxbell
commented
Mar 21, 2023
nfx
approved these changes
Mar 21, 2023
jxbell
commented
Mar 21, 2023
nfx
changed the title
enable_serverless_compute API changes in databricks_sql_endpoint resource
nfx
approved these changes
Mar 21, 2023
Merged
|
There is a FOLLOWUP PR for the Azure version of the DBSQL Serverless GA: #2249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPLOYMENT NOTE: TO BE DEPLOYED WITH AWS GA SERVERLESS SQL ON MARCH 22 AND IN CONJUNCTION WITH THIS DOCS PR: https://github.com/databricks/docs/pull/10197 PROBABLY BEST TO WAIT FOR CONFIRMATION OF GO/NOGO!
Three related PRs:
enable_serverless_computeAPI changes indatabricks_sql_endpointresource #2137DOC-6788 Terraform AWS serverless SQL API changes
IMPORTANT: NO API changes to remove global config field IN TERRAFORM CONTRACT PER @nfx -- HE DID DEPRECATE IT IN https://github.com/databricks/terraform-provider-databricks/pull/2139/files
Cleanup:
Cleanup: fix "sql endpoint" in English descriptions (not code/spec) to "SQL warehouse" per name change.
Cleanup: fix to lowercase for all this type of case for "serverless" (per Marketing Department dictum)
API change to regular
enable_serverless_computefield (not global config) :Update the
enable_serverless_computeguidance for AWS and Azure enablement: ((Make more accurate enablement info for AWS only (not "enable for workspace" since we don't do that as of GA). Azure doesn't need special terms of use flags at account level, but does have workspace flag) :If your account was created before October 1, 2021, your organization's owner or account administrator must [accept applicable terms of use](https://docs.databricks.com/sql/admin/serverless.html#accept-terms) before workspaces are enabled for serverless compute. A workspace must meet the [requirements](https://docs.databricks.com/sql/admin/serverless.html#requirements) and might require an update its instance profile role to [add a trust relationship](https://docs.databricks.com/sql/admin/serverless.html#aws-instance-profile-setup). For Azure, you must [enable your workspace for serverless SQL warehouse](https://learn.microsoft.com/azure/databricks/sql/admin/serverless).Also update that field per agreement with PM to match API Explorer and main docs... Update AWS specific instructions when we enable "auto enablement at account level" as part of GA for AWS
For AWS, Databricks strongly recommends that you always explicitly set this field. If omitted, the default is false for most workspaces. However, if this workspace used the SQL Warehouses API to create a warehouse between September 1, 2022 and April 6, 2023, the default remains the previous behavior which is default to true if the workspace is enabled for serverless and fits the requirements for serverless SQL warehouses. To avoid ambiguity, especially for organizations with many workspaces, Databricks recommends that you always set this field.For Azure, specify how default value works:
For Azure, if serverless SQL warehouses are disabled for the workspace, the default isfalse. If serverless SQL warehouses are enabled for the workspace, the default istrue.