Add caching of scim/me API to databricks_current_user data source and databricks_permissions resource.
#2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2170 +/- ##
==========================================
- Coverage 88.99% 88.79% -0.20%
==========================================
Files 137 137
Lines 11182 11209 +27
==========================================
+ Hits 9951 9953 +2
- Misses 827 849 +22
- Partials 404 407 +3
|
nfx
requested changes
Mar 29, 2023
common/client.go
Outdated
| if err != nil { | ||
| return user, err | ||
| } | ||
| *a.cachedUser = *user |
There was a problem hiding this comment.
why not a.cachedUser = user?..
There was a problem hiding this comment.
The pointer points to the cached user in client. This is why we need to copy into the cachedUser value.
There was a problem hiding this comment.
just make it cachedUser *scim.User on the client.
There was a problem hiding this comment.
That would not work I think. If we do this, then a.cachedUser = user will lead to the cachedUser within CachedUserService to point to the new user, but the changes won't be propagated to the client.
nfx
requested changes
Mar 29, 2023
common/client.go
Outdated
| if err != nil { | ||
| return user, err | ||
| } | ||
| *a.cachedUser = *user |
There was a problem hiding this comment.
just make it cachedUser *scim.User on the client.
kartikgupta-db
changed the title
databricks_current_user data source and databricks_permissions resource.
kartikgupta-db
changed the title
databricks_current_user data source and databricks_permissions resource.databricks_current_user data source and databricks_permissions resource.
nkvuong
pushed a commit
that referenced
this pull request
Mar 29, 2023
…nd `databricks_permissions` resource. (#2170) * Cache scim/me API * add mutext to protect cached user * naming fix * defer mu.unlock and remove unused code * cache ws client * inline method and rename
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
close #2120