Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document & export databricks_workspace_conf parameters for legacy init scripts #2280

Merged
merged 1 commit into from
May 10, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented May 9, 2023

Changes

given the recent advisory, there are asks for disabling the legacy global & named cluster init scripts via Terraform. This PR documents them, and also add to the exporter

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

…nit scripts

given the recent advisory, there are asks for disabling the legacy global & named cluster
init scripts via Terraform.  This PR documents them, and also add to the exporter
@alexott alexott requested review from a team May 9, 2023 18:38
@codecov-commenter
Copy link

Codecov Report

Merging #2280 (3ed1bcb) into master (3c2c2b5) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2280      +/-   ##
==========================================
- Coverage   88.74%   88.72%   -0.02%     
==========================================
  Files         140      140              
  Lines       11549    11550       +1     
==========================================
- Hits        10249    10248       -1     
- Misses        868      869       +1     
- Partials      432      433       +1     
Impacted Files Coverage Δ
exporter/context.go 84.52% <ø> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@nfx nfx merged commit 28cbf48 into master May 10, 2023
@nfx nfx deleted the legacy-init-scripts branch May 10, 2023 09:53
nfx added a commit that referenced this pull request May 12, 2023
# Version changelog

## 1.16.0

 * Added [databricks_workspace_file](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_file) resource ([#2266](#2266)).
 * Added `notification_settings` block to [databricks_job](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/job) resource ([#2276](#2276)).
 * Added missing permission to [databricks_aws_crossaccount_policy](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/aws_crossaccount_policy) data source ([#2283](#2283)).
 * Fixed [databricks_sql_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_table) doc ([#2281](#2281)).
 * Fixed doc on tag propagation and tag conflict for [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) resource ([#2242](#2242)).
 * Document & export [databricks_workspace_conf](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_conf) parameters for legacy init scripts ([#2280](#2280)).
 * Removed deprecated `CREATE_VIEW` from code of [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) resource ([#2230](#2230)).
 * Exporter: relax handling of problematic files/directories ([#2258](#2258)).
@nfx nfx mentioned this pull request May 12, 2023
nfx added a commit that referenced this pull request May 12, 2023
# Version changelog

## 1.16.0

 * Added [databricks_workspace_file](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_file) resource ([#2266](#2266)).
 * Added `notification_settings` block to [databricks_job](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/job) resource ([#2276](#2276)).
 * Added missing permission to [databricks_aws_crossaccount_policy](https://registry.terraform.io/providers/databricks/databricks/latest/docs/data-sources/aws_crossaccount_policy) data source ([#2283](#2283)).
 * Fixed [databricks_sql_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_table) doc ([#2281](#2281)).
 * Fixed doc on tag propagation and tag conflict for [databricks_instance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/instance_pool) resource ([#2242](#2242)).
 * Document & export [databricks_workspace_conf](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/workspace_conf) parameters for legacy init scripts ([#2280](#2280)).
 * Removed deprecated `CREATE_VIEW` from code of [databricks_grants](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants) resource ([#2230](#2230)).
 * Exporter: relax handling of problematic files/directories ([#2258](#2258)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants