Explicit conversion of strings to int64. #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2346 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 141 141
Lines 11642 11642
=======================================
Hits 10302 10302
Misses 890 890
Partials 450 450
|
|
Please let me know if you have any comments or suggestion of changes to this PR. |
|
Can you please rebase this branch to the latest |
Instead of machine dependant conversion when using integer type int. Will throw "value out of range" error for platforms that infer int as int32, when larger integers than int32 is used.
RicNord
force-pushed
the
fix/parsing-int64
branch
from
b701ceb to
c5bb4f3
Compare
|
Run aws-prod & aws-ucws acceptance tests. first one failed with not related error - for some reason cluster library wasn't installed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Explicit conversion of strings to
int64. Instead of machine dependent conversion when using integer typeint(bit size 0 instrconv.ParseInt), that will throw "value out of range" error for platforms that inferintasint32, when larger integers thanint32is used.Tests
make testrun locallydocs/folderinternal/acceptance