Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to databricks_cluster_policy data source #2351

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

840
Copy link
Contributor

@840 840 commented May 30, 2023

Changes

Adds the following attributes to the data source cluster policy:

  • description
  • policy_family_id
  • policy_family_definition_overrides
  • is_default

Closes #1947

Tests

I have modified the TestDataSourceClusterPolicy to test the cluster policy data structure using the new attributes.

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@iandexter iandexter requested a review from a team May 30, 2023 15:32
@codecov-commenter
Copy link

Codecov Report

Merging #2351 (f8a116d) into master (130c52d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2351   +/-   ##
=======================================
  Coverage   88.58%   88.59%           
=======================================
  Files         140      140           
  Lines       11546    11554    +8     
=======================================
+ Hits        10228    10236    +8     
  Misses        879      879           
  Partials      439      439           
Impacted Files Coverage Δ
common/version.go 80.00% <ø> (ø)
policies/data_cluster_policy.go 100.00% <100.00%> (ø)

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@alexott
Copy link
Contributor

alexott commented May 30, 2023

Acceptance tests are failing, but on not related tests (timeout)

@nfx nfx changed the title Add attributes to data source cluster policy Add attributes to databricks_cluster_policy data source Jun 7, 2023
@nfx nfx merged commit 039bdb2 into databricks:master Jun 7, 2023
@nfx nfx mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Feature to modify/override the Default Personal Compute Policy
4 participants