Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs and tests for databricks_volume resource #2355

Merged
merged 5 commits into from
May 31, 2023
Merged

Updated docs and tests for databricks_volume resource #2355

merged 5 commits into from
May 31, 2023

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented May 31, 2023

Changes

Address comments mentioned in: #2324

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

catalog/resource_volume_test.go Outdated Show resolved Hide resolved
docs/resources/volume.md Outdated Show resolved Hide resolved
docs/resources/volume.md Outdated Show resolved Hide resolved
@tanmay-db tanmay-db changed the title comments Updated docs and tests for databricks_volume resource May 31, 2023
@tanmay-db tanmay-db requested a review from nfx May 31, 2023 14:16
@codecov-commenter
Copy link

Codecov Report

Merging #2355 (7e521df) into master (fd509fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2355   +/-   ##
=======================================
  Coverage   88.56%   88.57%           
=======================================
  Files         141      141           
  Lines       11595    11603    +8     
=======================================
+ Hits        10269    10277    +8     
  Misses        883      883           
  Partials      443      443           
Impacted Files Coverage Δ
catalog/resource_volume.go 83.67% <100.00%> (+0.34%) ⬆️

... and 3 files with indirect coverage changes

@nfx nfx merged commit 9bbb300 into databricks:master May 31, 2023
@nfx nfx mentioned this pull request Jun 2, 2023
nfx added a commit that referenced this pull request Jun 2, 2023
 * Added [databricks_volume](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/volume) resource in Unity Catalog ([#2324](#2324)).
 * Added [databricks_model_serving](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/model_serving) support to [databricks_permissions](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/permissions) ([#2331](#2331)).
 * Added suppress diff for URL change that only changes `/` (remove or add) in UC resources ([#2336](#2336)).
 * Fixed attributes typo in SCIM API ([#2344](#2344)).
 * Fixed updates for [databricks_share](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/share) resource ([#2307](#2307)).
 * Updated documentation for [databricks_service_principal_secret](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/service_principal_secret) ([#2332](#2332)).
 * Updated documentation for troubleshooting guide with a typical error when creating groups/users on the Account level ([#2338](#2338)).
 * Other testing infrastructure improvements ([#2350](#2350), [#2355](#2355), [#2358](#2358)).

Updated dependency versions:

 * Bump github.com/hashicorp/hcl/v2 from 2.16.2 to 2.17.0 ([#2359](#2359)).
 * Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 ([#2354](#2354)).
 * Bump github.com/zclconf/go-cty from 1.13.1 to 1.13.2 ([#2329](#2329)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants