Add run_as and run_as_user_name field to job definition #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2366 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 141 141
Lines 11620 11620
=======================================
Hits 10288 10288
Misses 886 886
Partials 446 446
|
Co-authored-by: Gabor Ratky <gabor.ratky@databricks.com>
alexott
approved these changes
Jun 6, 2023
| @@ -88,6 +88,7 @@ The resource supports the following arguments: | |||
| * `email_notifications` - (Optional) (List) An optional set of email addresses notified when runs of this job begins, completes and fails. The default behavior is to not send any emails. This field is a block and is documented below. | |||
| * `webhook_notifications` - (Optional) (List) An optional set of system destinations (for example, webhook destinations or Slack) to be notified when runs of this job begins, completes and fails. The default behavior is to not send any notifications. This field is a block and is documented below. | |||
| * `schedule` - (Optional) (List) An optional periodic schedule for this job. The default behavior is that the job runs when triggered by clicking Run Now in the Jobs UI or sending an API request to runNow. This field is a block and is documented below. | |||
| * `run_as` - (Optional) An optional identifier of the user or the service principal that the job runs as. If not specified, the job runs as the user who created the job. This field is a block and is documented below. | |||
There was a problem hiding this comment.
Usually this list includes only direct attributes, and blocks are documented as separate sections.
Comment on lines
+204
to
+205
| UserName string `json:"user_name,omitempty"` | ||
| ServicePrincipalName string `json:"service_principal_name,omitempty"` |
There was a problem hiding this comment.
we may need to add a customization to set ConflictsWith between these two fields. Also, we may need to add checks that both strings aren't empty...
|
Please rebase on the latest |
nfx
approved these changes
Jun 8, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added read-only runAsUserName field to job definition and write-only runAs field to job settings definition. Fields are added in openAPI spec and are marked as private preview.
Tests
Tested e2e by running
terraform applyon a dev workspacemake testrun locallydocs/folderinternal/acceptance