Adding less permissive principal for self assuming UC role #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes:
- Replaced `*` per `arn:aws:iam::${var.aws_account_id}:root` for the self assuming part of the UC policy document role
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 141 141
Lines 11634 11642 +8
=======================================
+ Hits 10294 10302 +8
Misses 890 890
Partials 450 450
|
nfx
approved these changes
Jun 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
*perarn:aws:iam::${var.aws_account_id}:rootfor the self assuming part of the UC policy document roleChanges
Tests
make testrun locallydocs/folderinternal/acceptance