Allow to change custom_tags in databricks_instance_pool resource without recreating a pool
#2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without recreating a pool Please note that due API bug it's impossible to remove tags completely after they set, you can only change them.
alexott
force-pushed
the
instance-pools-tags-edit
branch
from
5e7324f to
e90fbe1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2400 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 141 141
Lines 11642 11642
=======================================
Hits 10302 10302
Misses 890 890
Partials 450 450
|
|
Does this work in all clouds? Could you do a manual test for this? I know there are some restrictions around changing tags on VMs e.g. in Azure, this was not supported or worked poorly in the past. |
|
I tested it on AWS & Azure, worked on both |
|
+1 for this merge. This is super useful for us (Grab) to update the pool tags. Thank @alexott for the pr. |
nfx
approved these changes
Jun 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
REST API supports editing of tags for quite a some time, but the field was still marked as
force_newleading to recreation of the pool & affecting dependent resources.Please note that due API bug it's impossible to remove tags completely after they set, you can only change them.
Tests
make testrun locallydocs/folderinternal/acceptance