Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assigning GCP SA in databricks_sql_global_config resource #2405

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

zjiaksmc
Copy link
Contributor

@zjiaksmc zjiaksmc commented Jun 14, 2023

Changes

Allow google_service_account to be assigned to SQL warehouse global settings.
This change impacts GCP Databricks workspace only. Corresponding REST API endpoint

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@zjiaksmc zjiaksmc marked this pull request as draft June 14, 2023 18:48
@zjiaksmc zjiaksmc marked this pull request as ready for review June 14, 2023 18:49
@zjiaksmc zjiaksmc marked this pull request as draft June 14, 2023 18:51
@alexott
Copy link
Contributor

alexott commented Jun 14, 2023

Tests most probably will fail. Also, update the docs

@alexott
Copy link
Contributor

alexott commented Jun 14, 2023

also, run make fmt

@alexott alexott requested review from a team June 14, 2023 18:55
@alexott
Copy link
Contributor

alexott commented Jun 14, 2023

you can add a separate test where fixture is create with Gcp: true

@zjiaksmc zjiaksmc marked this pull request as ready for review June 15, 2023 18:23
@zjiaksmc
Copy link
Contributor Author

@alexott I just incorporated all your suggestions.

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, although it would be nice to add a test for this branch

else {
  return fmt.Errorf("can't use google_service_account outside of GCP")
}

@nfx nfx changed the title Allow assigning gcp SA in sql global config Allow assigning GCP SA in databricks_sql_global_config resource Jun 19, 2023
@nfx nfx merged commit 032ec48 into databricks:master Jun 19, 2023
@mgyucht mgyucht mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants