Added gcp_attributes.local_ssd_count to databricks_cluster resource
#2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2422 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 142 142
Lines 11797 11798 +1
=======================================
+ Hits 10414 10415 +1
Misses 923 923
Partials 460 460
|
mgyucht
reviewed
Aug 2, 2023
clusters/resource_cluster.go
Outdated
| @@ -59,6 +59,8 @@ func resourceClusterSchema() map[string]*schema.Schema { | |||
| return common.StructToSchema(Cluster{}, func(s map[string]*schema.Schema) map[string]*schema.Schema { | |||
| s["spark_conf"].DiffSuppressFunc = SparkConfDiffSuppressFunc | |||
| common.MustSchemaPath(s, "aws_attributes", "zone_id").DiffSuppressFunc = ZoneDiffSuppress | |||
| common.MustSchemaPath(s, "gcp_attributes", "use_preemptible_executors").Deprecated = "Please use 'availability' instead." | |||
There was a problem hiding this comment.
Can we separate this into a separate commit? Otherwise it will not appear on the changelog.
New setting allows to specify number of local SSD disks to be attached to each node
alexott
force-pushed
the
gcp-cluster-local-ssds
branch
from
00e3279 to
1993b34
Compare
mgyucht
approved these changes
Aug 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New setting allows to specify number of local SSD disks to be attached to each node
Unfortunately we need to wait until Clusters GET is fixed because right now it doesn't return that attribute 🤦
Tests
make testrun locallydocs/folderinternal/acceptance