Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go SDK version to 0.12.0 #2442

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Bump Go SDK version to 0.12.0 #2442

merged 1 commit into from
Jun 29, 2023

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Jun 29, 2023 •
edited
Loading

Changes

Bump the Go SDK version to 0.12.0. This fixes the terraform provider to work in the DOD environment.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht requested review from alexott and tanmay-db June 29, 2023 08:05
@mgyucht
Copy link
Contributor Author

mgyucht commented Jun 29, 2023

All integration tests have passed except for

  • TestUcAccCatalogWorkspaceBinding - Known failure, currently failing on main nightly
  • TestAccModelServing - Known failure, currently under investigation.
    These tests are not regressions due to this change, so I think we are safe to merge.

@mgyucht mgyucht merged commit 83c0ace into master Jun 29, 2023
@mgyucht mgyucht deleted the go-sdk-0.12.0 branch June 29, 2023 11:24
@mgyucht mgyucht mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgyucht @alexott @tanmay-db