Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter: add support for databricks_model_serving #2512

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Exporter: add support for databricks_model_serving #2512

merged 1 commit into from
Aug 2, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jul 25, 2023

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners July 25, 2023 10:46
@codecov-commenter
Copy link

Codecov Report

Merging #2512 (c218c66) into master (7541e65) will decrease coverage by 0.01%.
The diff coverage is 87.87%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2512      +/-   ##
==========================================
- Coverage   88.21%   88.21%   -0.01%     
==========================================
  Files         145      145              
  Lines       11980    12013      +33     
==========================================
+ Hits        10568    10597      +29     
- Misses        929      931       +2     
- Partials      483      485       +2
Files Changed Coverage Δ
exporter/importables.go 89.09% <87.87%> (-0.04%) ⬇️

mgyucht
mgyucht approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgyucht mgyucht added this pull request to the merge queue Aug 2, 2023
Merged via the queue into master with commit 6fa03e3 Aug 2, 2023
@mgyucht mgyucht mentioned this pull request Aug 8, 2023
Merged
@alexott alexott added the exporter TF configuration generator label Feb 7, 2024
@nkvuong nkvuong deleted the exporter-model-serving branch February 23, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
exporter TF configuration generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexott @codecov-commenter @mgyucht