Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document missing environment variables for authentication #2541

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Document missing environment variables for authentication #2541

merged 1 commit into from
Aug 2, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Aug 1, 2023

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners August 1, 2023 11:39
nkvuong
nkvuong approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mgyucht mgyucht added this pull request to the merge queue Aug 2, 2023
Merged via the queue into master with commit d617479 Aug 2, 2023
@mgyucht mgyucht mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkvuong nkvuong nkvuong approved these changes

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexott @mgyucht @nkvuong