-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AWS IAM data helpers #255
Conversation
Hey @nfx, TravisBuddy Request Identifier: 5c8e3c20-e19a-11ea-81c3-ef1e647c3fbd |
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 62.37% 61.10% -1.28%
==========================================
Files 53 54 +1
Lines 6374 6512 +138
==========================================
+ Hits 3976 3979 +3
- Misses 2066 2201 +135
Partials 332 332
|
Condition map[string]map[string]string `json:"Condition,omitempty"` | ||
} | ||
|
||
func DataAwsCrossAccountRolicy() *schema.Resource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a docs page
} | ||
``` | ||
|
||
## Attribute Reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other docs in the repo make a clear distinction between attribute and argument.
Argument should be user inputs where attributes are outputs/read only values computed by the resource/datasource.
This should use the naming convention
Argument reference
<varname>
- (Required/Computed/Optional) (Datatype) (content)
Attribute reference
<varname>
- (Datatype) (content)
policy = data.databricks_aws_bucket_policy.this.json | ||
} | ||
``` | ||
## Argument Reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other docs in the repo make a clear distinction between attribute and argument.
Argument should be user inputs where attributes are outputs/read only values computed by the resource/datasource.
The bucket_name should be an argument where the json is an attribute.
This should use the naming convention
Argument reference
<varname>
- (Required/Computed/Optional) (Datatype) (content)
Attribute reference
<varname>
- (Datatype) (content)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make the following changes
Hey @nfx, TravisBuddy Request Identifier: 0abe0730-e641-11ea-aa37-f5f007553843 |
@stikkireddy will add documentation as requested in pre-release testing branch |
End-to-end example of provisioning Cross-account IAM role: