Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter: Added support for databricks_mlflow_webhook resources #2552

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Aug 2, 2023

Changes

Also fixed a bug in context.go related to generation of variables for nested attributes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

Also fixed a bug in `context.go` related to generation of variables for nested attributes
@alexott alexott requested review from a team as code owners August 2, 2023 17:28
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #2552 (4b2b931) into master (c8f3202) will increase coverage by 0.22%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2552      +/-   ##
==========================================
+ Coverage   87.96%   88.18%   +0.22%     
==========================================
  Files         145      145              
  Lines       12055    12078      +23     
==========================================
+ Hits        10604    10651      +47     
+ Misses        960      937      -23     
+ Partials      491      490       -1     
Files Changed Coverage Δ
exporter/importables.go 88.99% <81.81%> (+2.13%) ⬆️
exporter/context.go 83.86% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@mgyucht mgyucht self-requested a review August 7, 2023 15:54
@alexott alexott added the exporter TF configuration generator label Aug 8, 2023
@mgyucht mgyucht changed the title Added exporting of databricks_mlflow_webhook resources Exporter: Support databricks_mlflow_webhook resources Aug 9, 2023
@mgyucht mgyucht changed the title Exporter: Support databricks_mlflow_webhook resources Exporter: Supported databricks_mlflow_webhook resources Aug 9, 2023
@mgyucht mgyucht changed the title Exporter: Supported databricks_mlflow_webhook resources Exporter: Added support for databricks_mlflow_webhook resources Aug 9, 2023
@mgyucht mgyucht added this pull request to the merge queue Aug 9, 2023
Merged via the queue into master with commit 8f50ea1 Aug 9, 2023
@mgyucht mgyucht deleted the exporter-mlflow-webhooks branch August 10, 2023 04:09
@tanmay-db tanmay-db mentioned this pull request Aug 25, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants