Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for group rule set management #2561

Merged

Conversation

gauthamsunjay
Copy link
Contributor

@gauthamsunjay gauthamsunjay commented Aug 4, 2023

Changes

Documentation changes for group rule set management.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@gauthamsunjay gauthamsunjay requested review from a team as code owners August 4, 2023 22:35
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just few comments. But needs to be merged after #2555

name = "accounts/${local.account_id}/groups/${databricks_group.ds.id}/ruleSets/default"

grant_rules {
principals = [data.databricks_user.john.acl_principal_id]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged only after #2555 is merged - right now we have acl_principal_id only on resources

docs/resources/access_control_rule_set.md Outdated Show resolved Hide resolved
docs/resources/access_control_rule_set.md Outdated Show resolved Hide resolved
docs/resources/access_control_rule_set.md Show resolved Hide resolved
docs/resources/access_control_rule_set.md Show resolved Hide resolved
@mgyucht mgyucht requested a review from pietern August 7, 2023 15:54
@gauthamsunjay gauthamsunjay requested a review from alexott August 12, 2023 00:19
@codecov-commenter
Copy link

Codecov Report

Merging #2561 (8019a2e) into master (07b00b2) will decrease coverage by 0.10%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
- Coverage   88.19%   88.09%   -0.10%     
==========================================
  Files         145      145              
  Lines       12055    12108      +53     
==========================================
+ Hits        10632    10667      +35     
- Misses        935      944       +9     
- Partials      488      497       +9     

see 7 files with indirect coverage changes

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just need to make sure that it's merged together with or after #2555

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgyucht mgyucht added this pull request to the merge queue Aug 14, 2023
Merged via the queue into databricks:master with commit c35d4b7 Aug 14, 2023
@tanmay-db tanmay-db mentioned this pull request Aug 25, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants