-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for group rule set management #2561
Add instructions for group rule set management #2561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just few comments. But needs to be merged after #2555
name = "accounts/${local.account_id}/groups/${databricks_group.ds.id}/ruleSets/default" | ||
|
||
grant_rules { | ||
principals = [data.databricks_user.john.acl_principal_id] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be merged only after #2555 is merged - right now we have acl_principal_id
only on resources
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
- Coverage 88.19% 88.09% -0.10%
==========================================
Files 145 145
Lines 12055 12108 +53
==========================================
+ Hits 10632 10667 +35
- Misses 935 944 +9
- Partials 488 497 +9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. just need to make sure that it's merged together with or after #2555
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Documentation changes for group rule set management.
Tests
make test
run locallydocs/
folderinternal/acceptance