Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate library create to use go-sdk #2998

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Migrate library create to use go-sdk #2998

merged 1 commit into from
Dec 8, 2023

Conversation

edwardfeng-db
Copy link
Contributor

Changes

  • Migrate library create to use go-sdk
  • Remove the old schema s as it's no longer used

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@edwardfeng-db edwardfeng-db marked this pull request as ready for review December 6, 2023 15:28
@edwardfeng-db edwardfeng-db requested review from a team as code owners December 6, 2023 15:28
@edwardfeng-db edwardfeng-db requested review from mgyucht and removed request for a team December 6, 2023 15:28
mgyucht
mgyucht approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Are there still references to libraries.Library, or can we remove that as well?

@edwardfeng-db
Copy link
Contributor Author

Are there still references to libraries.Library, or can we remove that as well?
Will take a look and remove if possible in a follow-up PR. I think there might be references from cluster resources.

@edwardfeng-db edwardfeng-db added this pull request to the merge queue Dec 8, 2023
Merged via the queue into master with commit 01d3f64 Dec 8, 2023
7 checks passed
@edwardfeng-db edwardfeng-db deleted the edwardfeng-db/migrate-library-create branch December 8, 2023 12:41
@tanmay-db tanmay-db mentioned this pull request Dec 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardfeng-db @mgyucht