Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: consistent header levels and same doc structure #3007

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 8, 2023

Changes

In a number of resources the header levels were inconsistent for documentation about blocks (some were on the 2nd level, some on the 3rd, while most of the resources use the 3rd level). Also, changed the order of sections a bit to get a uniform order of sections.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

In a number of resources the header levels were inconsistent for documentation about
blocks (some were on 2nd level, some on 3rd, while most of resources use 3rd level).  Also
change order of sections a bit to get uniform order.
@alexott alexott added the docs add explicit documentation about corner case label Dec 8, 2023
@alexott alexott requested review from a team as code owners December 8, 2023 12:59
@alexott alexott requested review from hectorcast-db and removed request for a team December 8, 2023 12:59
@codecov-commenter
Copy link

Codecov Report

Merging #3007 (1ee33e3) into master (df9ff74) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
- Coverage   84.30%   84.26%   -0.04%     
==========================================
  Files         158      158              
  Lines       13835    13830       -5     
==========================================
- Hits        11663    11654       -9     
- Misses       1523     1525       +2     
- Partials      649      651       +2     

see 2 files with indirect coverage changes

@@ -405,7 +405,7 @@ resource "databricks_job" "sql_aggregation_job" {
}
```

### Exported attributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you replaced all the instances of this in the doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it was only one place with such a name - everything else uses "Attribute Reference"

Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment, otherwise lgtm

@alexott alexott added this pull request to the merge queue Dec 9, 2023
Merged via the queue into master with commit 58fdc3b Dec 9, 2023
7 checks passed
@alexott alexott deleted the doc-consistent-headers branch December 9, 2023 08:43
@tanmay-db tanmay-db mentioned this pull request Dec 19, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs add explicit documentation about corner case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants