Fix diff schema on PRs #3071
Merged
Fix diff schema on PRs #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3071 +/- ##
=======================================
Coverage 84.55% 84.55%
=======================================
Files 161 161
Lines 14187 14187
=======================================
Hits 11996 11996
Misses 1508 1508
Partials 683 683 |
edwardfeng-db
approved these changes
Jan 4, 2024
hectorcast-db
approved these changes
Jan 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The diff-schema workflow doesn't work anymore because it fails to checkout master. This PR should fix this by always checking out the base & head commits and passing those commits via env vars to
diff-schema.sh. With no variables set, it will show the diff between the current checked-out branch and master.Tests