Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating owner of databricks_connection #3080

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Jan 5, 2024

Changes

  • Allow updating owner of databricks_connection, now that the API supports it
  • Add GoogleServiceAccountKeyJson to list of secret options that are redacted by API

Closes #3079

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners January 5, 2024 22:19
@nkvuong nkvuong requested review from tanmay-db and removed request for a team January 5, 2024 22:19
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (2fe11af) 84.59% compared to head (fa4d3c6) 84.46%.
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
- Coverage   84.59%   84.46%   -0.14%     
==========================================
  Files         161      161              
  Lines       14214    14251      +37     
==========================================
+ Hits        12025    12037      +12     
- Misses       1507     1528      +21     
- Partials      682      686       +4     
Files Coverage Δ
catalog/resource_connection.go 60.22% <55.17%> (-7.42%) ⬇️

... and 3 files with indirect coverage changes

@nkvuong nkvuong added this pull request to the merge queue Jan 17, 2024
Merged via the queue into master with commit 72f8ff0 Jan 17, 2024
5 checks passed
@nkvuong nkvuong deleted the fix/connection branch January 17, 2024 10:26
@hectorcast-db hectorcast-db mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_connection resource
4 participants