Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use diffSuppressor instead of makeEmptyBlockSuppressFunc #3099

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Use diffSuppressor instead of makeEmptyBlockSuppressFunc #3099

merged 3 commits into from
Jan 10, 2024

Conversation

edwardfeng-db
Copy link
Contributor

@edwardfeng-db edwardfeng-db commented Jan 10, 2024 •
edited
Loading

Changes

  • As introduced in this PR, we don't have to use makeEmptyBlockSuppressFunc any more, simplifying this so that we can remove makeEmptyBlockSuppressFunc
  • Meanwhile modified the signature of diffSuppressor to take in the schema type so we don't have to use Sprintf every time we call this

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@edwardfeng-db edwardfeng-db marked this pull request as ready for review January 10, 2024 14:37
@edwardfeng-db edwardfeng-db requested review from a team as code owners January 10, 2024 14:37
@edwardfeng-db edwardfeng-db requested review from tanmay-db and mgyucht and removed request for a team January 10, 2024 14:37
@edwardfeng-db edwardfeng-db added this pull request to the merge queue Jan 10, 2024
Merged via the queue into master with commit e17c404 Jan 10, 2024
5 checks passed
@edwardfeng-db edwardfeng-db deleted the edwardfeng-db/diff-suppressor branch January 10, 2024 19:32
@tanmay-db tanmay-db mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@tanmay-db tanmay-db Awaiting requested review from tanmay-db tanmay-db was automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardfeng-db @mgyucht