Allow custom tags on AWS customer managed VPC workspaces #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonsmit30
changed the title
alexott
reviewed
Jan 14, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3114 +/- ##
==========================================
+ Coverage 83.99% 84.30% +0.31%
==========================================
Files 155 162 +7
Lines 13669 14414 +745
==========================================
+ Hits 11481 12152 +671
- Misses 1538 1565 +27
- Partials 650 697 +47
|
alexott
approved these changes
Jan 15, 2024
tanmay-db
approved these changes
Jan 15, 2024
|
|
||
| // UpdateRunning will update running workspace with couple of possible fields | ||
| func (a WorkspacesAPI) UpdateRunning(ws Workspace, timeout time.Duration) error { | ||
| workspacesAPIPath := fmt.Sprintf("/accounts/%s/workspaces/%d", ws.AccountID, ws.WorkspaceID) | ||
| request := map[string]string{} | ||
| request := map[string]any{} |
There was a problem hiding this comment.
custom tags are map of string to string right?
There was a problem hiding this comment.
yes it's a map, but this change is required because we need to nest custom tags inside the map that will be sent to Workspace API
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reference:
https://docs.databricks.com/api/account/workspaces/create
https://docs.databricks.com/api/account/workspaces/update
This will also solve issue #2938
At my company we want to try keep as much in terraform code as possible. We have a temporarily call once workspace is created to update the tags for billing purposes but keeping in terraform code would be more suitable!
Tests
Manually tested with Company Databricks account and workspace on AWS environment. Note tested via GCP / Azure as currently do not have access.
make testrun locallydocs/folderinternal/acceptanceThis is my first attempted open source contribution. I am also learning golang and tried to attempt this as a real problem to solve in my workplace. So feel free to scrutinize fully.