Migrate databricks_mws_private_access_settings to Go SDK
#3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyucht
requested review from
tanmay-db and
hectorcast-db
and removed request for
a team and
tanmay-db
| common.DataToStructPointer(d, s, &pas) | ||
| common.SetForceSendFields(&pas, d, []string{"public_access_enabled"}) | ||
| if err := NewPrivateAccessSettingsAPI(ctx, c).Create(&pas); err != nil { | ||
| res, err := a.PrivateAccess.Create(ctx, provisioning.UpsertPrivateAccessSettingsRequest(pas)) |
There was a problem hiding this comment.
Why do we create a new provisioning.UpsertPrivateAccessSettingsRequest ?
There was a problem hiding this comment.
Good catch. This doesn't make a new one but just does a type conversion to itself. Removing this now.
hectorcast-db
approved these changes
Jan 19, 2024
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Migrates this resource to the Go SDK. Also marks the
account_idfield at the resource level as deprecated, like what we did fordatabricks_mws_credentials.Tests
make testrun locallydocs/folderinternal/acceptance