Use double quotes with filters in SCIM #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyucht
requested review from
hectorcast-db and
alexott
and removed request for
a team
| @@ -18,7 +18,7 @@ func TestDataSourceGroup(t *testing.T) { | |||
| Fixtures: []qa.HTTPFixture{ | |||
| { | |||
| Method: "GET", | |||
| Resource: "/api/2.0/preview/scim/v2/Groups?filter=displayName%20eq%20%27ds%27", | |||
| Resource: `/api/2.0/preview/scim/v2/Groups?filter=displayName%20eq%20%22ds%22`, | |||
There was a problem hiding this comment.
nit, I don't think the string quotes need to be changed here
hectorcast-db
approved these changes
Jan 19, 2024
alexott
approved these changes
Jan 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The SCIM API team is changing the library used to parse SCIM requests. This library is more strict with the interpretation of filters, specifically mandating that string values in filters, like for display name or application ID, must use double quotes instead of single quotes. This PR modifies SCIM APIs to use double quotes for strings in filters instead.
Tests
make testrun locallydocs/folderinternal/acceptance