Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare version 0.2.5 #314

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Prepare version 0.2.5 #314

merged 3 commits into from
Sep 11, 2020

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Sep 10, 2020 •
edited
Loading

Version changelog

0.2.5

Accounts API

  • mws.TestMwsAccCreds (2.66s)
  • mws.TestMwsAccCustomerManagedKeys (1.26s)
  • mws.TestMwsAccMissingResources (2.55s)
  • mws.TestMwsAccMissingResources/Credential (0.32s)
  • mws.TestMwsAccMissingResources/Network (0.72s)
  • mws.TestMwsAccMissingResources/Storage (0.71s)
  • mws.TestMwsAccMissingResources/Workspace (0.79s)
  • mws.TestMwsAccStorageConfigurations (2.11s)
  • mws.TestMwsAccWorkspace (0.60s)
  • mws/acceptance.TestMwsAccCredentials (19.16s)
  • mws/acceptance.TestMwsAccNetworks (21.17s)
  • mws/acceptance.TestMwsAccStorageConfigurations (27.13s)
  • mws/acceptance.TestMwsAccWorkspaces (99.54s)

Azure CLI

FAIL: TestAccGroupResource_verify_entitlements (25.17s) - test runner error, will check if it repeats PASSED

  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (70.72s)
  • access/acceptance.TestAccSecretAclResource (39.85s)
  • access/acceptance.TestAccSecretResource (71.34s)
  • access/acceptance.TestAccSecretScopeResource (37.10s)
  • compute.TestAccContext (22.93s)
  • compute.TestAccInstancePools (6.56s)
  • compute.TestAccLibraryCreate (44.54s)
  • compute.TestAccListClustersIntegration (54.86s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (49.23s)
  • compute/acceptance.TestAccClusterResource_CreateClusterWithLibraries (165.31s)
  • compute/acceptance.TestAccJobResource (54.95s)
  • compute/acceptance.TestAzureAccClusterResource_CreateClusterViaInstancePool (281.19s)
  • identity.TestAccCreateAdminUser (18.25s)
  • identity.TestAccCreateToken (5.64s)
  • identity.TestAccCreateUser (12.50s)
  • identity.TestAccGetAdminGroup (5.36s)
  • identity.TestAccGroup (29.32s)
  • identity.TestAccRoleDifferences (8.11s)
  • identity/acceptance.TestAccGroupMemberResource (117.42s)
  • identity/acceptance.TestAccGroupResource (57.16s)
  • identity/acceptance.TestAccScimGroupResource (259.25s)
  • identity/acceptance.TestAccScimUserResource (472.78s)
  • identity/acceptance.TestAccTokenResource (46.50s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (3.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.50s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.44s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.17s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (0.25s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.20s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.19s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.18s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.19s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.18s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.21s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.12s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (0.35s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Users (0.19s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (9.38s)
  • storage.TestAccCreateFile (7.67s)
  • storage.TestAccDeleteInvalidMountFails (4.03s)
  • storage.TestAccInvalidSecretScopeFails (3.74s)
  • storage.TestAccSourceOnInvalidMountFails (26.75s)
  • storage.TestAzureAccBlobMount (136.09s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaContent (48.82s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaSource (122.26s)
  • storage/acceptance.TestAzureAccBlobMount_correctly_mounts (422.27s)
  • workspace/acceptance.TestAccNotebookResourceMultipleFormats (95.94s)
  • workspace/acceptance.TestAccNotebookResourceScalability (123.80s)

Azure Service Principal

* FAIL: TestAccTokenResource (65.78s) PASSED
* FAIL: TestAzureAccAdlsGen2Mount_capture_error (11.87s) Removed, as we already test this flow

  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (36.62s)
  • access/acceptance.TestAccSecretAclResource (20.99s)
  • access/acceptance.TestAccSecretResource (27.38s)
  • access/acceptance.TestAccSecretScopeResource (16.68s)
  • compute.TestAccContext (21.33s)
  • compute.TestAccInstancePools (2.80s)
  • compute.TestAccLibraryCreate (40.37s)
  • compute.TestAccListClustersIntegration (260.57s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (21.30s)
  • compute/acceptance.TestAccClusterResource_CreateClusterWithLibraries (244.67s)
  • compute/acceptance.TestAccJobResource (6.88s)
  • compute/acceptance.TestAzureAccClusterResource_CreateClusterViaInstancePool (292.28s)
  • identity.TestAccCreateAdminUser (9.44s)
  • identity.TestAccCreateToken (1.00s)
  • identity.TestAccCreateUser (5.04s)
  • identity.TestAccGetAdminGroup (1.38s)
  • identity.TestAccGroup (18.75s)
  • identity.TestAccRoleDifferences (3.07s)
  • identity/acceptance.TestAccGroupMemberResource (64.83s)
  • identity/acceptance.TestAccGroupResource (27.08s)
  • identity/acceptance.TestAccGroupResource_verify_entitlements (18.34s)
  • identity/acceptance.TestAccScimGroupResource (150.09s)
  • identity/acceptance.TestAccScimUserResource (177.54s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (2.39s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.33s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.36s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.08s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (0.51s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.09s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.11s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.11s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.08s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.04s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.04s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (0.37s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Users (0.12s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (3.62s)
  • storage.TestAccCreateFile (2.41s)
  • storage.TestAccDeleteInvalidMountFails (2.92s)
  • storage.TestAccInvalidSecretScopeFails (2.69s)
  • storage.TestAccSourceOnInvalidMountFails (26.71s)
  • storage.TestAzureAccADLSv1Mount (373.55s)
  • storage.TestAzureAccADLSv2Mount (129.64s)
  • storage.TestAzureAccBlobMount (129.03s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaContent (15.56s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaSource (12.53s)
  • storage/acceptance.TestAzureAccAdlsGen1Mount_correctly_mounts (701.36s)
  • storage/acceptance.TestAzureAccAdlsGen2Mount_correctly_mounts (167.68s)
  • storage/acceptance.TestAzureAccBlobMount_correctly_mounts (375.40s)
  • workspace/acceptance.TestAccNotebookResourceMultipleFormats (52.75s)
  • workspace/acceptance.TestAccNotebookResourceScalability (111.59s)

@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8e63ed70-f39d-11ea-addc-35ae975c2fab

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   64.90%   64.90%           
=======================================
  Files          55       55           
  Lines        6744     6744           
=======================================
  Hits         4377     4377           
  Misses       1996     1996           
  Partials      371      371
Impacted Files Coverage Δ
storage/mounts.go 81.06% <50.00%> (ø)

@nfx
Copy link
Contributor Author

nfx commented Sep 10, 2020

AZ SP got occasional Error: adal: Failed to execute the refresh request. Error = 'Post "https://login.microsoftonline.com/xxx/oauth2/token?api-version=1.0": net/http: TLS handshake timeout', which is more of ADAL issue

@nfx
Preparing version 0.2.5
c247002 
Removed TestAzureAccAdlsGen2Mount_capture_error because it's covered by TestAccInvalidSecretScopeFails already
@TravisBuddy
Copy link

Hey @nfx,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: af299680-f42f-11ea-a882-ef0b60d9fbb3

@nfx
Copy link
Contributor Author

nfx commented Sep 11, 2020

removed flaky tests, re-run occasional ones.

i can sign-off this version to be tagged for release.

stikkireddy
stikkireddy approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@stikkireddy stikkireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added one comment if you can please respond back to it that would be awesome @nfx

@nfx nfx merged commit e50f0c6 into master Sep 11, 2020
@nfx nfx deleted the prep/0.2.5 branch September 11, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stikkireddy stikkireddy stikkireddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nfx @TravisBuddy @codecov-commenter @stikkireddy