Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix databricks_grants example for metastore #3239

Conversation

donatasm
Copy link
Contributor

@donatasm donatasm commented Feb 9, 2024

Changes

Add required metastore argument for databricks_grants in metastore docs example.

Current example would return an error:

Error: Missing required argument
  with databricks_grants.catalog_staging,
  on [catalogs.tf](http://catalogs.tf/) line 24, in resource "databricks_grants" "catalog_staging":
  24: resource "databricks_grants" "catalog_staging" {
"model": one of
`catalog,external_location,foreign_connection,function,metastore,model,schema,share,storage_credential,table,volume`
must be specified

@donatasm donatasm requested review from a team as code owners February 9, 2024 10:45
@donatasm donatasm requested review from mgyucht and removed request for a team February 9, 2024 10:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c87b9fe) 83.76% compared to head (3d3d8d8) 83.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3239      +/-   ##
==========================================
+ Coverage   83.76%   83.79%   +0.02%     
==========================================
  Files         170      170              
  Lines       15177    15177              
==========================================
+ Hits        12713    12717       +4     
+ Misses       1718     1716       -2     
+ Partials      746      744       -2     

see 2 files with indirect coverage changes

@alexott alexott changed the title Fix docs in metastore databricks_grants example Docs: Fix databricks_grants example for metastore Feb 9, 2024
@alexott alexott added this pull request to the merge queue Feb 9, 2024
Merged via the queue into databricks:main with commit a3cc8a6 Feb 9, 2024
5 checks passed
@donatasm donatasm deleted the fix-docs-metastore-databricks_grants-example branch February 9, 2024 12:44
@tanmay-db tanmay-db mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants