PLAT-99110: Added terraform support for restrict ws admins setting #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauthamsunjay
requested review from
mgyucht
and removed request for
a team and
mgyucht
gauthamsunjay
commented
Feb 9, 2024
gauthamsunjay
commented
Feb 9, 2024
5 tasks
|
Can we add the unit test and integration tests (if possible)? |
|
We also need docs |
|
Yep, I am adding docs, unit tests and integration tests. Will ping when it is ready for review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3243 +/- ##
==========================================
+ Coverage 83.59% 83.60% +0.01%
==========================================
Files 171 172 +1
Lines 15444 15466 +22
==========================================
+ Hits 12910 12930 +20
- Misses 1771 1772 +1
- Partials 763 764 +1
|
gauthamsunjay
commented
Feb 16, 2024
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestAccRestrictWorkspaceAdminsSetting(t *testing.T) { |
There was a problem hiding this comment.
@hectorcast-db btw only account admin can modify this setting. Do acceptance tests always run as account admin?
gauthamsunjay
commented
Feb 16, 2024
|
@alexott @hectorcast-db the PR is ready for review. |
hectorcast-db
approved these changes
Feb 21, 2024
shinyehtsai-db
approved these changes
Feb 21, 2024
alexott
approved these changes
Feb 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Followed instructions in https://docs.google.com/document/d/1tXZCuZ1Vl6F3Syu23jQOaxguavTB3Mz_RugEafxdhik/edit to add terraform support for restrict workspace admins setting.
Tests
make testrun locallydocs/folderinternal/acceptance