Fix sql table column type upper and lower mismatch error #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Hi @case-k-git, thanks for creating the PR, there were other issues that needed to be fixed (mapping) and I have created the PR to include this along with integration test: #3528. Once that is merged, can you please rebase and your PR with unit test can be merged after it. |
|
Hi @tanmay-db Thank you for your comment. Sure!! |
case-k-git
force-pushed
the
feature/fix-sql-table-column-type-match-issue
branch
from
c26ba60 to
9d0ef1d
Compare
|
Hi @tanmay-db |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3501 +/- ##
=======================================
Coverage 81.64% 81.64%
=======================================
Files 193 193
Lines 19563 19563
=======================================
Hits 15973 15973
Misses 2637 2637
Partials 953 953 |
|
Hi @case-k-git, thanks for the PR. |
tanmay-db
approved these changes
Jun 4, 2024
pietern
added a commit
that referenced
this pull request
Jun 5, 2024
### New Features and Improvements * Added `gcp_workspace_sa` computed attribute to `databricks_mws_workspaces` ([#3617](#3617)). * Added `storage_credential_id` attribute to `databricks_storage_credential` resource ([#3636](#3636)). * Added `full_name` attribute to `databricks_system_schema` resource ([#3634](#3634)). * Fix SQL table column type throws error ([#3501](#3501)). * Add `aws_unity_catalog_assume_role_policy` data source ([#3622](#3622)). * Fix bug for job creation with `num_workers = 0` ([#3642](#3642)). ### Documentation Changes * Document support of `requirements.txt` specification in cluster libraries ([#3637](#3637)). * Clarify about trailing slash character in file arrival trigger URL in `databricks_job` resource ([#3635](#3635)). Dependency updates: * Bump golang.org/x/mod from 0.17.0 to 0.18.0 ([#3643](#3643)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Release v1.47.0 ### New Features and Improvements * Added `gcp_workspace_sa` computed attribute to `databricks_mws_workspaces` ([#3617](#3617)). * Added `storage_credential_id` attribute to `databricks_storage_credential` resource ([#3636](#3636)). * Added `full_name` attribute to `databricks_system_schema` resource ([#3634](#3634)). * Fix SQL table column type throws error ([#3501](#3501)). * Add `aws_unity_catalog_assume_role_policy` data source ([#3622](#3622)). * Fix bug for job creation with `num_workers = 0` ([#3642](#3642)). ### Documentation Changes * Document support of `requirements.txt` specification in cluster libraries ([#3637](#3637)). * Clarify about trailing slash character in file arrival trigger URL in `databricks_job` resource ([#3635](#3635)). Dependency updates: * Bump golang.org/x/mod from 0.17.0 to 0.18.0 ([#3643](#3643)). * Update CHANGELOG.md
pietern
added a commit
that referenced
this pull request
Jun 5, 2024
* Release v1.47.0 ### New Features and Improvements * Added `gcp_workspace_sa` computed attribute to `databricks_mws_workspaces` ([#3617](#3617)). * Added `storage_credential_id` attribute to `databricks_storage_credential` resource ([#3636](#3636)). * Added `full_name` attribute to `databricks_system_schema` resource ([#3634](#3634)). * Fix SQL table column type throws error ([#3501](#3501)). * Add `aws_unity_catalog_assume_role_policy` data source ([#3622](#3622)). * Fix bug for job creation with `num_workers = 0` ([#3642](#3642)). ### Documentation Changes * Document support of `requirements.txt` specification in cluster libraries ([#3637](#3637)). * Clarify about trailing slash character in file arrival trigger URL in `databricks_job` resource ([#3635](#3635)). Dependency updates: * Bump golang.org/x/mod from 0.17.0 to 0.18.0 ([#3643](#3643)). * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Terraform manage column type by lower case so if add the Upper case terraform
Terraform manages column types in lowercase, so passing them in uppercase results in a column mismatch error.Even if not changing column type
fix this error
#3490
Tests
make testrun locallydocs/folderinternal/acceptance