Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed case sensitivity for principals in databricks_grants and databricks_grant #3708

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Jun 26, 2024

Changes

Tests

  • make test run locally
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners June 26, 2024 07:40
@nkvuong nkvuong requested review from mgyucht and removed request for a team June 26, 2024 07:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.66%. Comparing base (c976219) to head (34013ee).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3708      +/-   ##
==========================================
+ Coverage   81.65%   81.66%   +0.01%     
==========================================
  Files         197      197              
  Lines       19731    19731              
==========================================
+ Hits        16111    16113       +2     
+ Misses       2660     2659       -1     
+ Partials      960      959       -1     
Files Coverage Δ
catalog/resource_grant.go 82.69% <100.00%> (ø)
catalog/resource_grants.go 86.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

@nkvuong
Copy link
Contributor Author

nkvuong commented Jun 26, 2024

integration tests passed (failed test is model serving)

@nkvuong nkvuong added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit dfbcb5c Jun 26, 2024
5 checks passed
@nkvuong nkvuong deleted the fix/grant-principal-sensitive branch June 26, 2024 10:27
hectorcast-db added a commit that referenced this pull request Jun 27, 2024
### New Features and Improvements
* Fixed case sensitivity for principals in `databricks_grants` and `databricks_grant` ([#3708](#3708)).

### Documentation Changes
* Update cluster policy doc ([#3707](#3707)).

### Internal Changes
* Refactor some common functions for workspace bindings ([#3702](#3702)).
@hectorcast-db hectorcast-db mentioned this pull request Jun 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 27, 2024
### New Features and Improvements
* Fixed case sensitivity for principals in `databricks_grants` and `databricks_grant` ([#3708](#3708)).

### Documentation Changes
* Update cluster policy doc ([#3707](#3707)).

### Internal Changes
* Refactor some common functions for workspace bindings ([#3702](#3702)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_grant resource on external_location introduced on 1.48.0
3 participants